Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opsgenie): Add support for setting note in Opsgenie notification #271

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

esatakyol
Copy link
Contributor

This PR adds support for setting the note field in the Opsgenie notifications.

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (743f877) 55.50% compared to head (72f5513) 55.47%.

Files Patch % Lines
pkg/services/opsgenie.go 37.50% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   55.50%   55.47%   -0.04%     
==========================================
  Files          35       35              
  Lines        3412     3425      +13     
==========================================
+ Hits         1894     1900       +6     
- Misses       1242     1248       +6     
- Partials      276      277       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@pasha-codefresh pasha-codefresh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@pasha-codefresh pasha-codefresh merged commit 7a06976 into argoproj:master Feb 19, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants