Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes log warning regarding indexer and may improve perf. Closes #1345 #2761

Merged
merged 1 commit into from
Nov 24, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Nov 23, 2019

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

Closes #1345

@codecov
Copy link

codecov bot commented Nov 23, 2019

Codecov Report

Merging #2761 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2761      +/-   ##
==========================================
- Coverage   38.37%   38.33%   -0.05%     
==========================================
  Files         156      156              
  Lines       17289    17292       +3     
  Branches      203      203              
==========================================
- Hits         6635     6629       -6     
- Misses       9831     9844      +13     
+ Partials      823      819       -4
Impacted Files Coverage Δ
util/rbac/rbac.go 74.63% <100%> (+0.18%) ⬆️
util/settings/settings.go 30.63% <100%> (+0.13%) ⬆️
controller/appcontroller.go 44.97% <100%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73a1a7c...0266285. Read the comment docs.

@alexec alexec marked this pull request as ready for review November 24, 2019 22:12
@alexec alexec marked this pull request as ready for review November 24, 2019 22:12
@alexec alexec merged commit 257c276 into argoproj:master Nov 24, 2019
@alexec alexec deleted the fix-indexers branch November 24, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants