fix(controller): add missing namespace index from workflow informer #12666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the namespace index missing from the workflow informer the healthz endpoint could not list namespace indexes. Leading to the following warning message everytime the healthz endpoint is called. This fix has been verified in our environment. Related Slack thread: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1707918209805259 Signed-off-by: Ryan Currah <[email protected]>
Joibel
approved these changes
Feb 15, 2024
agilgur5
approved these changes
Feb 15, 2024
|
Thanks for root causing this and fixing it! |
|
No problem @agilgur5! |
This was referenced Feb 15, 2024
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 20, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 27, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Feb 28, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]> Signed-off-by: Isitha Subasinghe <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
Mar 12, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
…rgoproj#12666) Signed-off-by: Ryan Currah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the namespace index missing from the workflow informer the healthz endpoint could not list namespace indexes.
Leading to the following warning message:
Everytime the healthz endpoint is called.
This fix has been verified in our environment by building the
workflow-controllerimage from scratch and deploying it.Related Slack thread: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1707918209805259
Fixes
Fixes healthz endpoint not being able to list namespace indexes.
Motivation
These changes are similar to what others have done to resolve the issue.
Modifications
Added the namespace index to the workflow informer.
Verification
Deployed to our environment hit the healthz endpoint with
curl http://127.0.0.1:6060/healthzand checked for the log message. It no longer appears.