Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create an external redis for ArgoCD externalRedis feature step on CI fails #2460

Closed
yu-croco opened this issue Jan 28, 2024 · 4 comments
Closed
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. bug Something isn't working

Comments

@yu-croco
Copy link
Collaborator

yu-croco commented Jan 28, 2024

Describe the bug

CI fails in these days regardless of code change in argo-helm.
helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set architecture=standalone gets timeout.

logic: https://github.com/argoproj/argo-helm/blob/main/.github/workflows/lint-and-test.yml#L93-L98
Failed CI ref: https://github.com/argoproj/argo-helm/actions/runs/7686011562/job/20944366344?pr=2459
image

There are some merged PRs in bitnami/redis recently and I wonder they give us breaking change.

Related helm chart

argo-cd

Helm chart version

5.53.10 (I think it happens in any version's CI)

To Reproduce

Run CI of argo-cd
e.g. https://github.com/argoproj/argo-helm/actions/runs/7686011562/job/20944366344?pr=2459

Expected behavior

CI passes

Screenshots

image

Additional context

No response

@yu-croco
Copy link
Collaborator Author

upstream's issue: bitnami/charts#22746

@yu-croco
Copy link
Collaborator Author

yu-croco commented Jan 28, 2024

Quick workaround📝
🆖 helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set architecture=standalone
🆗 helm install redis bitnami/redis --wait --namespace redis --set auth.password=argocd --set architecture=replication

Ref: https://github.com/argoproj/argo-helm/actions/runs/7686212929/job/20944815409?pr=2459

*Maybe we have other workarounds.

@yu-croco
Copy link
Collaborator Author

This issue will be fixed in bitnami/charts#22747.

@yu-croco yu-croco added the awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. label Jan 28, 2024
@yu-croco
Copy link
Collaborator Author

upstream is merged and CI fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
argo-cd awaiting-upstream Is waiting for a change upstream to be completed before it can be merged. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant