[bitnami/redis] Do not create master and replica serviceaccounts when using sentinel

[wilmardo]

Description of the change

Currently when choosing to use sentinel you get all the serviceaccounts not just the one needed.

Currently is creates the master and replica service accounts:

default          0         8h
redis1           0         73m
redis1-master    0         64s
redis1-replica   0         64s
redis2           0         51m
redis2-master    0         62s
redis2-replica   0         62s

Benefits

Less clutter, removes unneeded resources. More inline with the other resources in the master/ and replica/ template folder. They all have this if check, this is the one resource where it was missing.

Checklist

• Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
• Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
• Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
• All commits signed off and in agreement of Developer Certificate of Origin (DCO)

[wilmardo]

I could add a check like this to the serviceaccount creation: ``` {{- if and .Values.sentinel.enabled .Values.serviceAccount.create }} ``` Which would be more inline with the previous if statement but to me it makes more sense that the `ServiceAccount` creation only depends on the true/false of the `.Values.serviceAccount.create`. The `RoleBinding` references this `ServiceAccount` for example so then a working statement would be:

{{- if  and .Values.serviceAccount.create .Values.sentinel.enabled .Values.rbac.create }}

Again, just depending on the create true/false makes more sense to avoid edge cases like this in the future

Not relevant, solved in #22223

[italoiz]

Is this PR a duplicate of #22223 ?

[Mauraza]

Hi @wilmardo,

Thanks for the contribution!! Could you check the conflicts?

[wilmardo]

@italoiz yes excuse me duplicated indeed. Dedupped the PR and changed the description/title to reflect the dedup

@Mauraza rebased and resolved the conflicts.

[Mauraza]

Hi @wilmardo,

Thanks for the contribution!!! LGTM!!