Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(argo-cd): Add existingVolumes setting for remaining deployments with emptyDir volumes #2456

Closed
wants to merge 2 commits into from
Closed

feat(argo-cd): Add existingVolumes setting for remaining deployments with emptyDir volumes #2456

wants to merge 2 commits into from

Conversation

bodgit
Copy link
Contributor

@bodgit bodgit commented Jan 26, 2024 •
edited
Loading

#2410 added the existingVolumes setting for the repo-server component. This PR adds an equivalent setting to the other Argo CD components that have emptyDir volumes in their deployment so you can either use a PVC or further tune the emptyDir volume with sizeLimit parameters, etc. (which is what I do).

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

@yu-croco
Copy link
Collaborator

FYI
Regarding the failed CI, #2460 is related. There is a PR for fixing in upstream, let's wait for it.

@yu-croco
Copy link
Collaborator

FYI: The CI is fixed now. 👍

@bodgit
Copy link
Contributor Author

bodgit commented Jan 30, 2024

@yu-croco Rebased and all tests now pass.

@bodgit bodgit requested a review from pdrastil January 31, 2024 10:36
yu-croco
yu-croco approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 6, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Apr 14, 2024
@mbevc1 mbevc1 reopened this Apr 14, 2024
@mbevc1
Copy link
Collaborator

mbevc1 commented Apr 14, 2024

Probably needs rebasing rather than closing? 🤔

@yu-croco
Copy link
Collaborator

Hi @bodgit , can you please fetch latest remote diff and resolve conflicts?

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mkilchhofer
Copy link
Member

not stale

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot closed this Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yu-croco yu-croco yu-croco approved these changes

@mbevc1 mbevc1 Awaiting requested review from mbevc1 mbevc1 is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer mkilchhofer is a code owner

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@tico24 tico24 Awaiting requested review from tico24 tico24 is a code owner

@pdrastil pdrastil Awaiting requested review from pdrastil pdrastil is a code owner

Assignees
No one assigned
Labels
argo-cd no-pr-activity size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bodgit @yu-croco @mbevc1 @mkilchhofer @pdrastil