feat(argo-cd): Use new Argo CD extension mechanism #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-croco
force-pushed
the
use-new-extension-ecosystem
branch
from
a3e07ec
to
81c8e08
Compare
Signed-off-by: yu-croco <[email protected]>
yu-croco
force-pushed
the
use-new-extension-ecosystem
branch
from
81c8e08
to
74e2b8d
Compare
Signed-off-by: yu-croco <[email protected]>
yu-croco
commented
Dec 30, 2023
Comment on lines
+363
to
+364
| {{- if or .Values.server.initContainers (and .Values.server.extensions.enabled .Values.server.extensions.extensionList) }} | ||
| initContainers: |
There was a problem hiding this comment.
Condition is so naive 🙃
yu-croco
commented
Dec 30, 2023
Comment on lines
+1598
to
+1603
| # - name: extension-metrics | ||
| # env: | ||
| # - name: EXTENSION_URL | ||
| # value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz | ||
| # - name: EXTENSION_CHECKSUM_URL | ||
| # value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt |
There was a problem hiding this comment.
yu-croco
commented
Dec 30, 2023
| # -- Server UI extensions container-level security context | ||
| # @default -- See [values.yaml] | ||
| containerSecurityContext: | ||
| runAsNonRoot: true | ||
| readOnlyRootFilesystem: true | ||
| allowPrivilegeEscalation: false | ||
| runAsUser: 1000 |
There was a problem hiding this comment.
I got container has runAsNonRoot and image has non-numeric user ... , so I added as following sample
Signed-off-by: yu-croco <[email protected]>
yu-croco
force-pushed
the
use-new-extension-ecosystem
branch
from
d976c89
to
a16af50
Compare
Signed-off-by: yu-croco <[email protected]>
yu-croco
commented
Dec 30, 2023
Comment on lines
-17
to
-19
| {{- if .Values.server.extensions.enabled }} | ||
| - argocdextensions | ||
| {{- end }} |
There was a problem hiding this comment.
argocdextensions CRD is removed ♻️
There was a problem hiding this comment.
to be honest, it should be a breaking release of the chart
There was a problem hiding this comment.
Yes, so I bumped minor version as following Versioning and put changelog in README.
Do you mean that bumping major version is more reasonable? 👀
yu-croco
requested review from
mbevc1,
mkilchhofer,
jmeridth,
pdrastil and
tico24
as code owners
tico24
approved these changes
Dec 30, 2023
pdrastil
approved these changes
Dec 30, 2023
jmeridth
approved these changes
Dec 30, 2023
|
👍🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2396
Checklist: