-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(argo-cd): Use new Argo CD extension mechanism #2406
Changes from 4 commits
74e2b8d
030c33d
a16af50
d83b4dc
af54232
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
# Test Argo CD extension | ||
crds: | ||
keep: false | ||
# Ref: https://github.com/argoproj-labs/argocd-extension-metrics?tab=readme-ov-file#install-ui-extension | ||
server: | ||
extensions: | ||
enabled: true | ||
extensionList: | ||
- name: extension-metrics | ||
env: | ||
- name: EXTENSION_URL | ||
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz | ||
- name: EXTENSION_CHECKSUM_URL | ||
value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -357,13 +357,22 @@ spec: | |
lifecycle: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
{{- with .Values.server.extraContainers }} | ||
{{- tpl (toYaml .) $ | nindent 6 }} | ||
{{- end }} | ||
{{- if or .Values.server.initContainers (and .Values.server.extensions.enabled .Values.server.extensions.extensionList) }} | ||
initContainers: | ||
Comment on lines
+363
to
+364
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Condition is so naive 🙃 |
||
{{- with .Values.server.initContainers }} | ||
{{- tpl (toYaml .) $ | nindent 6 }} | ||
{{- end }} | ||
{{- if .Values.server.extensions.enabled }} | ||
- name: argocd-extensions | ||
image: {{ .Values.server.extensions.image.repository }}:{{ .Values.server.extensions.image.tag }} | ||
imagePullPolicy: {{ .Values.server.extensions.image.imagePullPolicy }} | ||
{{- range .Values.server.extensions.extensionList }} | ||
- name: {{ .name }} | ||
image: {{ $.Values.server.extensions.image.repository }}:{{ $.Values.server.extensions.image.tag }} | ||
imagePullPolicy: {{ default $.Values.global.image.imagePullPolicy $.Values.server.extensions.image.imagePullPolicy }} | ||
resources: | ||
{{- toYaml .Values.server.extensions.resources | nindent 10 }} | ||
{{- with .Values.server.extensions.containerSecurityContext }} | ||
{{- toYaml $.Values.server.extensions.resources | nindent 10 }} | ||
{{- with $.Values.server.extensions.containerSecurityContext }} | ||
securityContext: | ||
{{- toYaml . | nindent 10 }} | ||
{{- end }} | ||
|
@@ -372,13 +381,10 @@ spec: | |
mountPath: /tmp/extensions/ | ||
- name: tmp | ||
mountPath: /tmp | ||
env: | ||
{{- toYaml .env | nindent 10 }} | ||
{{- end }} | ||
{{- with .Values.server.extraContainers }} | ||
{{- tpl (toYaml .) $ | nindent 6 }} | ||
{{- end }} | ||
{{- with .Values.server.initContainers }} | ||
initContainers: | ||
{{- tpl (toYaml .) $ | nindent 6 }} | ||
{{- end }} | ||
{{- with include "argo-cd.affinity" (dict "context" . "component" .Values.server) }} | ||
affinity: | ||
|
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1574,29 +1574,41 @@ server: | |
# -- Specify postStart and preStop lifecycle hooks for your argo-cd-server container | ||
lifecycle: {} | ||
|
||
## Argo UI extensions | ||
## Argo CD extensions | ||
## This function in tech preview stage, do expect instability or breaking changes in newer versions. | ||
## Ref: https://github.com/argoproj-labs/argocd-extensions | ||
## Ref: https://github.com/argoproj-labs/argocd-extension-installer | ||
extensions: | ||
# -- Enable support for Argo UI extensions | ||
# -- Enable support for Argo CD extensions | ||
enabled: false | ||
|
||
## Argo UI extensions image | ||
## Argo CD extension installer image | ||
image: | ||
# -- Repository to use for extensions image | ||
repository: "ghcr.io/argoproj-labs/argocd-extensions" | ||
# -- Tag to use for extensions image | ||
tag: "v0.2.1" | ||
# -- Repository to use for extension installer image | ||
repository: "quay.io/argoprojlabs/argocd-extension-installer" | ||
# -- Tag to use for extension installer image | ||
tag: "v0.0.1" | ||
# -- Image pull policy for extensions | ||
# @default -- `""` (defaults to global.image.imagePullPolicy) | ||
imagePullPolicy: "" | ||
|
||
# -- Extensions for Argo CD | ||
# @default -- `[]` (See [values.yaml]) | ||
## Ref: https://github.com/argoproj-labs/argocd-extension-metrics#install-ui-extension | ||
extensionList: [] | ||
# - name: extension-metrics | ||
# env: | ||
# - name: EXTENSION_URL | ||
# value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension.tar.gz | ||
# - name: EXTENSION_CHECKSUM_URL | ||
# value: https://github.com/argoproj-labs/argocd-extension-metrics/releases/download/v1.0.0/extension_checksums.txt | ||
Comment on lines
+1598
to
+1603
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
||
# -- Server UI extensions container-level security context | ||
# @default -- See [values.yaml] | ||
containerSecurityContext: | ||
runAsNonRoot: true | ||
readOnlyRootFilesystem: true | ||
allowPrivilegeEscalation: false | ||
runAsUser: 1000 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I got |
||
seccompProfile: | ||
type: RuntimeDefault | ||
capabilities: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
argocdextensions CRD is removed ♻️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be honest, it should be a breaking release of the chart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so I bumped minor version as following Versioning and put changelog in README.
Do you mean that bumping major version is more reasonable? 👀