fix: keep rs inormer updated upon updating labels and annotations (#3321

) * fix: keep rs inormer updated upon updating labels and annotations Signed-off-by: Zach Aller <[email protected]> * give error some context Signed-off-by: Zach Aller <[email protected]> --------- Signed-off-by: Zach Aller <[email protected]>
argoproj · Jan 24, 2024 · 07355a0 · 07355a0
1 parent 31fe59b
commit 07355a0
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/rollout/ephemeralmetadata.go b/rollout/ephemeralmetadata.go
@@ -2,6 +2,7 @@ package rollout
 
 import (
 	"context"
+	"fmt"
 
 	appsv1 "k8s.io/api/apps/v1"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -81,9 +82,13 @@ func (c *rolloutContext) syncEphemeralMetadata(ctx context.Context, rs *appsv1.R
 	}
 
 	// 2. Update ReplicaSet so that any new pods it creates will have the metadata
-	_, err = c.kubeclientset.AppsV1().ReplicaSets(modifiedRS.Namespace).Update(ctx, modifiedRS, metav1.UpdateOptions{})
+	rs, err = c.kubeclientset.AppsV1().ReplicaSets(modifiedRS.Namespace).Update(ctx, modifiedRS, metav1.UpdateOptions{})
 	if err != nil {
-		return err
+		return fmt.Errorf("error updating replicaset in syncEphemeralMetadata: %w", err)
+	}
+	err = c.replicaSetInformer.GetIndexer().Update(rs)
+	if err != nil {
+		return fmt.Errorf("error updating replicaset informer in syncEphemeralMetadata: %w", err)
 	}
 	c.log.Infof("synced ephemeral metadata %v to ReplicaSet %s", podMetadata, rs.Name)
 	return nil