Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep rs inormer updated upon updating labels and annotations #3321

Merged
merged 2 commits into from
Jan 24, 2024
Merged

fix: keep rs inormer updated upon updating labels and annotations #3321

merged 2 commits into from
Jan 24, 2024

Conversation

zachaller
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

Go Published Test Results

2 093 tests   2 093 ✅  2m 49s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 25fbf8d.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024 •
edited
Loading

E2E Tests Published Test Results

  4 files    4 suites   3h 28m 24s ⏱️
106 tests  98 ✅  6 💤  2 ❌
440 runs  400 ✅ 24 💤 16 ❌

For more details on these failures, see this check.

Results for commit 25fbf8d.

♻️ This comment has been updated with latest results.

@zachaller
give error some context
25fbf8d 
Signed-off-by: Zach Aller <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
8.6% Duplication on New Code

See analysis details on SonarCloud

@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (180b4bf) 81.83% compared to head (25fbf8d) 81.82%.
Report is 4 commits behind head on master.

Files Patch % Lines
rollout/ephemeralmetadata.go 33.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3321      +/-   ##
==========================================
- Coverage   81.83%   81.82%   -0.02%     
==========================================
  Files         135      135              
  Lines       20633    20637       +4     
==========================================
+ Hits        16885    16886       +1     
- Misses       2877     2879       +2     
- Partials      871      872       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

leoluz
leoluz approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller merged commit 07355a0 into argoproj:master Jan 24, 2024
22 of 23 checks passed
zachaller added a commit that referenced this pull request Jan 24, 2024
@zachaller
fix: keep rs inormer updated upon updating labels and annotations (#3321
eded8a1 
)

* fix: keep rs inormer updated upon updating labels and annotations

Signed-off-by: Zach Aller <[email protected]>

* give error some context

Signed-off-by: Zach Aller <[email protected]>

---------

Signed-off-by: Zach Aller <[email protected]>
@zachaller zachaller added the cherry-pick-completed Used once we have cherry picked the PR to all requested releases label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoluz leoluz leoluz approved these changes

Assignees
No one assigned
Labels
cherry-pick/release-1.6 cherry-pick-completed Used once we have cherry picked the PR to all requested releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachaller @leoluz