Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollout_phase is marked deprecated in code but not the docs #2377

Closed
1 of 2 tasks
blkperl opened this issue Oct 26, 2022 · 1 comment · Fixed by #2378
Closed
1 of 2 tasks

rollout_phase is marked deprecated in code but not the docs #2377

blkperl opened this issue Oct 26, 2022 · 1 comment · Fixed by #2378
Assignees
@iam-veeramalla
Labels
docs Needs documentation/release notes good first issue Good for newcomers

Comments

@blkperl
Copy link
Contributor

blkperl commented Oct 26, 2022 •
edited
Loading

Checklist:

  • I've included steps to reproduce the bug.
  • I've inclued the version of argo rollouts.

Describe the bug

rollout_phase is marked deprecated in code but not in the docs

Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritize the issues with the most 👍.
@blkperl blkperl added bug Something isn't working good first issue Good for newcomers docs Needs documentation/release notes and removed bug Something isn't working labels Oct 26, 2022
@iam-veeramalla
Copy link
Member

I will add the deprecation notice to the docs. Assigning it to myself.

@iam-veeramalla iam-veeramalla self-assigned this Oct 27, 2022
iam-veeramalla added a commit to iam-veeramalla/argo-rollouts that referenced this issue Oct 27, 2022
@iam-veeramalla
chore: add deprecation notice for rollout_phase in docs (argoproj#2377)
3bc3820 
Signed-off-by: iam-veeramalla <[email protected]>
@iam-veeramalla iam-veeramalla mentioned this issue Oct 27, 2022
Merged
6 tasks
@Nishant-sehgal Nishant-sehgal mentioned this issue Nov 3, 2022
Closed
6 tasks
zachaller pushed a commit that referenced this issue Nov 8, 2022
@iam-veeramalla
chore: add deprecation notice for rollout_phase in docs (#2377) (#2378)
9fb4647 
Signed-off-by: iam-veeramalla <[email protected]>

Signed-off-by: iam-veeramalla <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue Nov 8, 2022
@iam-veeramalla @jandersen-plaid
chore: add deprecation notice for rollout_phase in docs (argoproj#2377)…
88a6c93 
… (argoproj#2378)

Signed-off-by: iam-veeramalla <[email protected]>

Signed-off-by: iam-veeramalla <[email protected]>
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this issue Nov 26, 2022
@iam-veeramalla @jandersen-plaid
chore: add deprecation notice for rollout_phase in docs (argoproj#2377)…
0bce8e4 
… (argoproj#2378)

Signed-off-by: iam-veeramalla <[email protected]>

Signed-off-by: iam-veeramalla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iam-veeramalla iam-veeramalla

Labels
docs Needs documentation/release notes good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: add deprecation notice for rollout_phase in docs (#2377) iam-veeramalla/argo-rollouts
2 participants
@blkperl @iam-veeramalla