-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated rollout_phase metrics details for rollout objects #2393
Conversation
Codecov ReportBase: 82.76% // Head: 82.76% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2393 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 121 121
Lines 18536 18536
=======================================
Hits 15341 15341
Misses 2410 2410
Partials 785 785 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
229e365
to
01c74f9
Compare
Can you follow the same formating as #2378 |
Signed-off-by: Nishant Sehgal <[email protected]>
12b1956
to
fa70958
Compare
Kudos, SonarCloud Quality Gate passed! |
Done. i just realized these 2 pr's are exactly the same. What should be done ? |
You are correct they are the same I could have swore they where on two different things going to close this in favor of the first one. Thanks for the PR though even though it was already done :D |
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.Issue: #2377
Description: Updated documentation for rollout object.rollout_phase is marked deprecated in code but not in the docs