Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated rollout_phase metrics details for rollout objects #2393

Closed
wants to merge 2 commits into from

Conversation

Nishant-sehgal
Copy link

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Issue: #2377
Description: Updated documentation for rollout object.rollout_phase is marked deprecated in code but not in the docs

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

Go Published Test Results

1 778 tests   1 778 ✔️  2m 31s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 5441d9a.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (5441d9a) compared to base (076ea43).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2393   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18536    18536           
=======================================
  Hits        15341    15341           
  Misses       2410     2410           
  Partials      785      785           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 3, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 39m 46s ⏱️
  89 tests   80 ✔️ 3 💤 6
184 runs  172 ✔️ 6 💤 6

For more details on these failures, see this check.

Results for commit 5441d9a.

♻️ This comment has been updated with latest results.

@zachaller
Copy link
Collaborator

Can you follow the same formating as #2378

@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Nishant-sehgal
Copy link
Author

Can you follow the same formating as #2378

Done. i just realized these 2 pr's are exactly the same. What should be done ?

@zachaller
Copy link
Collaborator

Can you follow the same formating as #2378

Done. i just realized these 2 pr's are exactly the same. What should be done ?

You are correct they are the same I could have swore they where on two different things going to close this in favor of the first one. Thanks for the PR though even though it was already done :D

@zachaller zachaller closed this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants