Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add port flag for dashboard command. Fixes #2382 #2383

Merged

Conversation

shibataka000
Copy link
Contributor

@shibataka000 shibataka000 commented Oct 31, 2022

Fixes #2382 .

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@shibataka000 shibataka000 changed the title feat(cli): add port flag for dashboard command. feat(cli): add port flag for dashboard command. Fixes #2382 Oct 31, 2022
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 82.76% // Head: 82.76% // No change to project coverage 👍

Coverage data is based on head (8fadd78) compared to base (076ea43).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2383   +/-   ##
=======================================
  Coverage   82.76%   82.76%           
=======================================
  Files         121      121           
  Lines       18536    18536           
=======================================
  Hits        15341    15341           
  Misses       2410     2410           
  Partials      785      785           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

Go Published Test Results

1 778 tests   1 778 ✔️  2m 31s ⏱️
   101 suites         0 💤
       1 files           0

Results for commit 8fadd78.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2022

E2E Tests Published Test Results

    2 files      2 suites   1h 28m 42s ⏱️
  89 tests   84 ✔️ 3 💤 2
180 runs  172 ✔️ 6 💤 2

For more details on these failures, see this check.

Results for commit 8fadd78.

♻️ This comment has been updated with latest results.

@shibataka000 shibataka000 force-pushed the add-port-flag-for-dashboard-command branch from 634edf4 to 7a03a91 Compare October 31, 2022 13:38
@shibataka000 shibataka000 marked this pull request as ready for review October 31, 2022 14:09
@zachaller zachaller added the ready-for-review Ready for final review label Oct 31, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zachaller zachaller merged commit 91043a9 into argoproj:master Nov 7, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 8, 2022
jandersen-plaid pushed a commit to jandersen-plaid/argo-rollouts that referenced this pull request Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-review Ready for final review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard's port should be able to be changed.
2 participants