Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump k8s versions to 1.29 #3494

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

zachaller
Copy link
Collaborator

@zachaller zachaller commented Apr 2, 2024

Bump k8s client libs, had to adjust some timing on one test because the new version of k8s seems a bit faster at creating the job for analysis. The test while checking for 1 is valid though. Had to bump prometheus deps down because of kubernetes/kubernetes#123547 (comment)

Signed-off-by: Zach Aller <[email protected]>
Copy link
Contributor

github-actions bot commented Apr 2, 2024

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 9470afc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

E2E Tests Published Test Results

  6 files    6 suites   5h 28m 13s ⏱️
110 tests  96 ✅  6 💤  8 ❌
694 runs  624 ✅ 36 💤 34 ❌

For more details on these failures, see this check.

Results for commit 9470afc.

♻️ This comment has been updated with latest results.

Signed-off-by: Zach Aller <[email protected]>
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.87%. Comparing base (8405f2e) to head (9470afc).
Report is 72 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   81.83%   82.87%   +1.03%     
==========================================
  Files         135      135              
  Lines       20688    17142    -3546     
==========================================
- Hits        16931    14206    -2725     
+ Misses       2883     2043     -840     
- Partials      874      893      +19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
9.5% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@leoluz leoluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachaller zachaller changed the title chore: bump k8s versions chore: bump k8s versions 1.29 Apr 2, 2024
@zachaller zachaller changed the title chore: bump k8s versions 1.29 chore: bump k8s versions to 1.29 Apr 2, 2024
@zachaller zachaller merged commit 2dc71e3 into argoproj:master Apr 2, 2024
29 checks passed
@jinleileiking
Copy link

matchLabelKeys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants