fix(controller): use the stableRS from the rollout context rather tha… #3664
Conversation
Go Published Test Results2 173 tests 2 173 ✅ 2m 55s ⏱️ Results for commit e1692ff. ♻️ This comment has been updated with latest results. |
E2E Tests Published Test Results 4 files 4 suites 3h 26m 45s ⏱️ For more details on these failures, see this check. Results for commit e1692ff. ♻️ This comment has been updated with latest results. |
benminter-treatwell
force-pushed
the
fix/post-promotion-scaling-events-cause-irreconcilable-rollout
branch
from
c99fdac
to
4e31b41
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3664 +/- ##
==========================================
+ Coverage 84.19% 84.32% +0.13%
==========================================
Files 154 154
Lines 18025 18022 -3
==========================================
+ Hits 15176 15197 +21
+ Misses 2003 1990 -13
+ Partials 846 835 -11 ☔ View full report in Codecov by Sentry. |
benminter-treatwell
force-pushed
the
fix/post-promotion-scaling-events-cause-irreconcilable-rollout
branch
from
b8030de
to
f06a8bf
Compare
benminter-treatwell
force-pushed
the
fix/post-promotion-scaling-events-cause-irreconcilable-rollout
branch
from
754a16d
to
459d9ac
Compare
|
Doing a rebase to keep this up to date and ready to go |
Published E2E Test Results 4 files 4 suites 3h 24m 32s ⏱️ For more details on these failures, see this check. Results for commit 29ac6ae. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 176 tests 2 176 ✅ 2m 55s ⏱️ Results for commit 29ac6ae. ♻️ This comment has been updated with latest results. |
|
@zachaller dropping a nudge here, would be awesome to get this merged! |
…n inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates Signed-off-by: ben.minter <[email protected]>
Signed-off-by: ben.minter <[email protected]>
Signed-off-by: ben.minter <[email protected]>
… by the reconiliation on start, by checking the log Signed-off-by: ben.minter <[email protected]>
zachaller
force-pushed
the
fix/post-promotion-scaling-events-cause-irreconcilable-rollout
branch
from
c2667ba
to
29ac6ae
Compare
|
#3664) * fix(controller): use the stableRS from the rollout context rather than inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates Signed-off-by: ben.minter <[email protected]> * fix(controller): update tests which were relying on this bug(?) Signed-off-by: ben.minter <[email protected]> * fix(controller): add clarity to comment in the case there is no stableRS Signed-off-by: ben.minter <[email protected]> * fix(controller): add a test to assert that the stablers is not scaled by the reconiliation on start, by checking the log Signed-off-by: ben.minter <[email protected]> --------- Signed-off-by: ben.minter <[email protected]>
zachaller
added
the
cherry-pick-completed
…n inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates. Fixes #3663
Checklist:
"fix(controller): Updates such and such. Fixes #1234".