Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): use the stableRS from the rollout context rather tha… #3664

Merged
merged 4 commits into from
Aug 6, 2024
Merged

fix(controller): use the stableRS from the rollout context rather tha… #3664

merged 4 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. fix(controller): use the stableRS from the rollout context rather tha… 

    …n inferring it from the active selector, to deal with the edge case where the stableRS != activeRS during analysis templates

Signed-off-by: ben.minter <[email protected]>
    @benminter-treatwell @zachaller
    benminter-treatwell authored and zachaller committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    d3d2e59 View commit details
    Browse the repository at this point in the history

  2. fix(controller): update tests which were relying on this bug(?) 

    Signed-off-by: ben.minter <[email protected]>
    @benminter-treatwell @zachaller
    benminter-treatwell authored and zachaller committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    cf7bf9b View commit details
    Browse the repository at this point in the history

  3. fix(controller): add clarity to comment in the case there is no stableRS 

    Signed-off-by: ben.minter <[email protected]>
    @benminter-treatwell @zachaller
    benminter-treatwell authored and zachaller committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    92efb33 View commit details
    Browse the repository at this point in the history

  4. fix(controller): add a test to assert that the stablers is not scaled… 

    … by the reconiliation on start, by checking the log

Signed-off-by: ben.minter <[email protected]>
    @benminter-treatwell @zachaller
    benminter-treatwell authored and zachaller committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    29ac6ae View commit details
    Browse the repository at this point in the history