Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aws-sdk-go to support IRSA #1774

Closed
dcherman opened this issue Nov 15, 2019 · 1 comment · Fixed by #1899
Closed

Update aws-sdk-go to support IRSA #1774

dcherman opened this issue Nov 15, 2019 · 1 comment · Fixed by #1899
Labels
type/feature Feature request
Milestone

Comments

@dcherman
Copy link
Member

In order to support IAM Roles for Service Accounts, the minimum version of the Go SDK needs to be 1.23.13 (https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts-minimum-sdk.html). It's currently 1.23.8.

The use case is rather than explicitly providing access key/secrets, we can instead allow a role to be used for access to S3 for artifact storage. While that is technically supported right now, it requires the use of either kube2iam or kiam rather than the officially supported solution.

@sarabala1979 sarabala1979 added this to the v2.5 milestone Nov 15, 2019
@sarabala1979 sarabala1979 added the type/feature Feature request label Nov 15, 2019
@sarabala1979
Copy link
Member

we will update the dependency v1.25.35 next release.

dcherman added a commit to dcherman/pkg that referenced this issue Dec 10, 2019
The minimum version of aws-sdk-go is documented to be 1.23.13.  This
will be a prerequisite for argoproj/argo-workflows#1774
dcherman added a commit to dcherman/pkg that referenced this issue Dec 10, 2019
The minimum version of aws-sdk-go is documented to be 1.23.13.  This
will be a prerequisite for argoproj/argo-workflows#1774
dcherman added a commit to dcherman/pkg that referenced this issue Dec 10, 2019
The minimum version of aws-sdk-go is documented to be 1.23.13.  This
will be a prerequisite for argoproj/argo-workflows#1774
dcherman added a commit to dcherman/argo that referenced this issue Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
2 participants