Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(artifacts): Add support for IAM roles for service accounts in artifact storage. Fixes #1774 #1899

Merged
merged 1 commit into from
Jan 3, 2020

Conversation

dcherman
Copy link
Member

@dcherman dcherman commented Jan 2, 2020

Fixes #1774

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234". Why? for the release notes.
  • Optional. I've added My organization is added to the README.
  • I've signed the CLA and required builds are green.

@alexec alexec changed the title feat: support iam roles for service accounts in artifact storage feat(artifacts): Add support for IAM roles for service accounts in artifact storage. Fixes #1774 Checklist: Jan 2, 2020
@alexec alexec changed the title feat(artifacts): Add support for IAM roles for service accounts in artifact storage. Fixes #1774 Checklist: feat(artifacts): Add support for IAM roles for service accounts in artifact storage. Fixes #1774 Jan 2, 2020
@alexec alexec self-assigned this Jan 2, 2020
@alexec alexec requested a review from whynowy January 2, 2020 18:29
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval. Can merged with green builds.

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1899 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1899   +/-   ##
=======================================
  Coverage   11.14%   11.14%           
=======================================
  Files          35       35           
  Lines       23536    23536           
=======================================
  Hits         2624     2624           
  Misses      20576    20576           
  Partials      336      336

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 160a794...3731365. Read the comment docs.

@alexec alexec merged commit 59a1906 into argoproj:master Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aws-sdk-go to support IRSA
2 participants