Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: change from v.3.5.2 suffix to release-3.5.2 #12460

Closed
wants to merge 1 commit into from
Closed

docs: change from v.3.5.2 suffix to release-3.5.2 #12460

wants to merge 1 commit into from

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jan 4, 2024

Relates to #12414

Motivation

Backport doc changes

Modifications

change from tag to branch since backported changes will be to the branch and also this matches what ArgoCD is doing to help keep our projects in sync

grep command I ran locally (OSX) to update the urls

 grep -ilr 'https:\/\/argo-workflows.readthedocs.io\/en\/v3.5.2' * | xargs -I@ sed -i '' 's/https:\/\/argo-workflows.readthedocs.io\/en\/v3.5.2/https:\/\/argo-workflows.readthedocs.io\/en\/release-3.5.2/g' @

Verification

@jmeridth
docs: change from v.3.5.2 suffix to release-3.5.2
2769597 
change from tag to branch since backported changes will be to the branch
and also this matches what ArgoCD is doing to help keep our projects
in sync

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth assigned jmeridth and unassigned jmeridth Jan 4, 2024
@jmeridth jmeridth added the area/docs Incorrect, missing, or mistakes in docs label Jan 4, 2024
@agilgur5 agilgur5 mentioned this pull request Jan 4, 2024
Merged
7 tasks
agilgur5
agilgur5 reviewed Jan 4, 2024
View reviewed changes
Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rather use release-3.5 with just the minor? As discussed in #12450 (comment) and #12414 (comment)

@jmeridth
Copy link
Member Author

jmeridth commented Jan 4, 2024

I thought we realized those pointed to 3.5.0 and 3.4.0. So not the latest docs on the minor version. Right?

@jmeridth
Copy link
Member Author

jmeridth commented Jan 4, 2024

Ah. If we sync the branch we'll be good. Ok. Will close this PR and do one to release-3.5 branch.

@jmeridth jmeridth closed this Jan 4, 2024
@jmeridth
Copy link
Member Author

jmeridth commented Jan 4, 2024

@agilgur5 continued in #12462

@jmeridth jmeridth mentioned this pull request Jan 4, 2024
Merged
2 tasks
@terrytangyuan terrytangyuan reopened this Jan 5, 2024
@terrytangyuan terrytangyuan changed the base branch from release-3.5.2 to release-3.5 January 5, 2024 14:37
@agilgur5 agilgur5 added the solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) label Feb 17, 2024
@agilgur5 agilgur5 added the type/backport Backport of an existing PR to an older release branch label Mar 9, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 left review comments

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan

Assignees
No one assigned
Labels
area/docs Incorrect, missing, or mistakes in docs solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/backport Backport of an existing PR to an older release branch
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.
3 participants
@jmeridth @agilgur5 @terrytangyuan