Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update doc links to readthedocs/release-3.5 #12462

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Jan 4, 2024

Formerly #12460

Relates to #12414

Motivation

Modifications

Verification

@jmeridth
Copy link
Member Author

jmeridth commented Jan 4, 2024

😢 my one commit (docs links changes) is signed (passes DCO). others seems to not have signed thiers and they were merged into release-3.5.2.

@jmeridth jmeridth added the area/docs Incorrect, missing, or mistakes in docs label Jan 4, 2024
@agilgur5
Copy link
Member

agilgur5 commented Jan 4, 2024

Most of them have sign-offs, just that they have changed over time based on the logs? Some of the merge commits appear to not have them though (their source PRs do have them though).

@terrytangyuan maybe it makes sense if you just fast-forward the release-3.5 branch to match release-3.5.2? and then JM can rebase on top of that.
We also may want to create a release-3.5.0 branch or tag since that doesn't currently exist. EDIT: well the v3.5.0 tag does exist so we don't necessarily need to do that actually, as the branch would otherwise be unused at this point.

@jmeridth
Copy link
Member Author

jmeridth commented Jan 4, 2024

@agilgur5 @terrytangyuan either way. I'm good. I await response.

@terrytangyuan
Copy link
Member

Can you do a rebase? I updated the release branch

@jmeridth
Copy link
Member Author

jmeridth commented Jan 5, 2024

@terrytangyuan on it

- [x] updated github issues config (like we did in main) to point to latest

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth changed the title docs: merge relase-3.5.2 into release-3.5 and update doc links to readthedocs/release-3.5 docs: update doc links to readthedocs/release-3.5 Jan 5, 2024
@jmeridth
Copy link
Member Author

jmeridth commented Jan 5, 2024

@terrytangyuan done

@terrytangyuan terrytangyuan merged commit 797f18d into argoproj:release-3.5 Jan 5, 2024
7 checks passed
@jmeridth
Copy link
Member Author

jmeridth commented Jan 5, 2024

https://argo-workflows.readthedocs.io/en/release-3.5/ is live

@jmeridth jmeridth deleted the jm-update-docs-links branch January 5, 2024 17:47
@agilgur5 agilgur5 added the type/backport Backport of an existing PR to an older release branch label Mar 9, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Incorrect, missing, or mistakes in docs type/backport Backport of an existing PR to an older release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants