Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump github.com/vektra/mockery from v2.26.0 to v2.42.0 #12713

Merged
merged 10 commits into from
Mar 24, 2024
Merged

chore(deps): bump github.com/vektra/mockery from v2.26.0 to v2.42.0 #12713

merged 10 commits into from
Mar 24, 2024

Conversation

blkperl
Copy link
Contributor

@blkperl blkperl commented Feb 29, 2024 •
edited
Loading

Motivation

This is part of a series of PRs to update build dependencies until the build no longer panics on Golang 1.22

Modifications

The new version of mockery generated some new files and no other changes were made.

Verification

No verification, the tests will fail if the mock changes do not work.

@blkperl blkperl marked this pull request as ready for review February 29, 2024 04:35
@blkperl blkperl changed the title chore(deps): bump github.com/vektra/mockery to v2.42.0 chore(deps): bump github.com/vektra/mockery from v2.26.0 to v2.42.0 Feb 29, 2024
terrytangyuan
terrytangyuan approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terrytangyuan terrytangyuan enabled auto-merge (squash) February 29, 2024 04:41
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies labels Feb 29, 2024
auto-merge was automatically disabled February 29, 2024 17:10

Head branch was pushed to by a user without write access

@blkperl
Copy link
Contributor Author

blkperl commented Mar 5, 2024

@isubasinghe Hey, I need help on the nix change for this PR as well. Thanks!

@blkperl
Copy link
Contributor Author

blkperl commented Mar 8, 2024

@isubasinghe I'm unsure how to get the new SHA. I wasn't able to see it fail when I run nix develop in the github codespace.

@isubasinghe
Copy link
Member

isubasinghe commented Mar 11, 2024 •
edited by agilgur5
Loading

@isubasinghe I'm unsure how to get the new SHA. I wasn't able to see it fail when I run nix develop in the github codespace.

error: hash mismatch in fixed-output derivation '/nix/store/akhi4m5mxiz1m5352ddc59q6w2kxjvw0-source.drv':
         specified: sha256-3wJ7XY/wfVXB4nEHLqEtNRscow/KrAo79sr2OgJisSY=
            got:    sha256-wwt7rhHWPlYtvudWKb8vk8t19MeN7AMfMugs0XeBDVk=

Weird that you aren't getting these error msgs, could be do to with a buggy version of nix then?

@isubasinghe
Copy link
Member

#12719 (comment)

isubasinghe
isubasinghe approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@isubasinghe isubasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isubasinghe isubasinghe enabled auto-merge (squash) March 11, 2024 11:45
auto-merge was automatically disabled March 11, 2024 19:26

Head branch was pushed to by a user without write access

@blkperl
Copy link
Contributor Author

blkperl commented Mar 11, 2024

@isubasinghe Thanks, I've updated the SHA. It should be good to go once CI passes.

@blkperl
chore: trigger ci
564c46e 
Signed-off-by: William Van Hevelingen <[email protected]>
@agilgur5 agilgur5 mentioned this pull request Mar 12, 2024
Merged
agilgur5
agilgur5 approved these changes Mar 24, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-ran CI since the failure was an unrelated test flake (see #12836 and Slack thread), passed this time around.

Deps LGTM, and if Isitha said Nix was good, then all clear 🚀

@agilgur5 agilgur5 merged commit bcc483e into argoproj:main Mar 24, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@agilgur5 agilgur5 agilgur5 approved these changes

@isubasinghe isubasinghe isubasinghe approved these changes

Assignees
No one assigned
Labels
go Pull requests that update Go dependencies type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@blkperl @isubasinghe @terrytangyuan @agilgur5