chore(deps): Bump sigs.k8s.io/controller-tools/cmd/controller-gen from v0.4.1 to v0.14.0

[blkperl]

Motivation

This PR upgrades controller-gen to a modern version of controller-gen. The prior version was released in 2020. Some of the manipulation in https://github.com/argoproj/argo-workflows/blob/main/hack/crds.go may no longer be required but it doesn't change the final result either way.

This is part of a series of PRs to update build dependencies until the build no longer panics on Golang 1.22

Modifications

The new version of controller-gen adds additional x-kubernetes-map-type which is described in kubernetes/kubernetes#84113. The map-type is manipulated in https://github.com/argoproj/argo-workflows/blob/main/hack/crds.go#L65 and was added in #6350. This manipulation may no longer be required.

Verification

I didn't do any manual testing as any issues would be caught by e2e tests.

[blkperl]

Anyone know why it built without having to change sha256 or vendorHash?

[agilgur5]

Good question; this is beyond my knowledge of Nix, cc @isubasinghe

[isubasinghe]

Did you run nix develop, this package isn't part of the build only the shell.

error: hash mismatch in fixed-output derivation '/nix/store/ajavbdx0j71cp0fp509z84anmgmc29mv-source.drv':
         specified: sha256-NQlSP9hRLXr+iZo0OeyF1MQs3PourQZN0I0v4Wv5dkE=
            got:    sha256-G0jBQ12cpjfWGhXYppV9dB2n68bExi6ME9QbxXsUWvw=

[blkperl]

Any idea why it doesn't throw the error for me?

(devenv) @blkperl ➜ ~/go/src/github.com/argoproj/argo-workflows (controller-gen) $ nix develop --extra-experimental-features nix-command --extra-experimental-features flakes ./dev/nix/ 
wait-for minio
deployment.apps/minio condition met
port-forward minio 9000
Forwarding from 127.0.0.1:9000 -> 9000
Forwarding from [::1]:9000 -> 9000
port-forward minio 9001
Forwarding from 127.0.0.1:9001 -> 9001
Forwarding from [::1]:9001 -> 9001
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
Done in 0.54s.
(devenv) @blkperl ➜ ~/go/src/github.com/argoproj/argo-workflows (controller-gen) $ 

[isubasinghe]

Weird, could it be a a cache thing perhaps?

[agilgur5]

Could you fill out the PR template? That would be helpful in describing the rationale, as well as explaining why all the lines got added in the CRDs and why one of the options was removed. E.g. linking to the relevant docs or changelogs for posterity

[agilgur5]

Looks like all of the >1000 LoC added to the CRDs is this same line

[blkperl]

It's a feature of modern versions of K8s and is described here: kubernetes/kubernetes#84113 .

It is manipulated here but there is no comments describing why.

https://github.com/argoproj/argo-workflows/blob/main/hack/crds.go#L65

[agilgur5]

It looks like it might still be necessary per #6350's logic. x-kubernetes-map-type: atomic was already used, but this dep change ended up adding it to more places -- why more were added due to this version of controller-gen is not entirely clear.

[agilgur5]

Good question; this is beyond my knowledge of Nix, cc @isubasinghe

[isubasinghe]

I've specified the correct hash in the comment, should be a quick fix.

[blkperl]

@isubasinghe I've added the suggested SHA.

[isubasinghe]

Note: doesn't build under Nix anyway.

Will fix this myself.

@blkperl feel free to make changes and just ping me that you upgraded a dependency next time, I will take responsibility for the Nix until its a bit more automated (in terms of hash fixing).