Problem: BS5 theme has typography issues and inconsistencies #1698
Assignees
Labels
Type: bug
A flaw in the code that causes the software to produce an incorrect or unexpected result.
Milestone
Comments
anvit
changed the title
anvit
added a commit
that referenced
this issue
Nov 2, 2023
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold and strong tags to 700
anvit
added a commit
that referenced
this issue
Nov 2, 2023
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold and strong tags to 700
anvit
added a commit
that referenced
this issue
Nov 3, 2023
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold and strong tags to 700
anvit
added a commit
that referenced
this issue
Nov 8, 2023
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold text to 700
anvit
added a commit
that referenced
this issue
Nov 8, 2023
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold text to 700
anvit
added
the
Type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The BS5 theme has some missing styles due to using
reboot.scssfrom Bootstrap, which exists to remove the default styles that browsers add to HTML tags. This can be desirable while building a new theme from the ground up, but in our case has lead to theblockquote,code,pretags missing some essential styling.A few examples of this can be found when using markdown. Here is what the BS2 version looks like
Compare this to the BS5 version
Another issue that comes from
reboot.scssis that the default sans serif typeface issystem-ui. This leads to different users having widely different experiences, for instance: most current Windows versions default toSegoe UItypeface which doesn't ship with a500weight font, and as a result they won't see any sections with the<strong>tag with having any kind of emphasis applied:Here is what it looks like on Ubuntu 22.04 for comparison:
The text was updated successfully, but these errors were encountered: