Fix BS5 typography issues (#1698) #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anvit
added
the
Type: bug
anvit
force-pushed
the
dev/issue-1698-typography-fixes
branch
from
3bb4d1c
to
2e292d1
Compare
|
I went with the 700 font-weight for
|
melaniekung
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
Nice work, especially with the image in the description! 💯
Only thought I had was the use of @use in _typography.scss. I know that Sass is trying to deprecate the use of @import but currently, all our .scss files uses @import so do we want to keep them consistent for now?
Otherwise looks good to me!
anvit
force-pushed
the
dev/issue-1698-typography-fixes
branch
from
2e292d1
to
0c0c011
Compare
jraddaoui
approved these changes
Nov 7, 2023
anvit
force-pushed
the
dev/issue-1698-typography-fixes
branch
from
1bf666f
to
8fceab6
Compare
Added the Open Sans typeface as set it as the default sans-serif typeface for the BS5 theme. Also added the following style changes: - Left border and padding for blockquote tags. - Background color for code and pre tags. - Padding for code and pre tags. - Whitespace wrapping for code tags. - Set the default font-weight for bold text to 700
anvit
force-pushed
the
dev/issue-1698-typography-fixes
branch
from
8fceab6
to
9f59fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Open Sans typeface (which is what arDominionPlugin uses) and set it as the default sans-serif typeface for the BS5 theme.
Also added the following style changes:
Here's what it looks like with these styling changes applied:
