Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple attributes to be specified #12

Closed
mojavelinux opened this issue Dec 13, 2016 · 2 comments
Closed

Allow multiple attributes to be specified #12

mojavelinux opened this issue Dec 13, 2016 · 2 comments

Comments

@mojavelinux
Copy link
Member

It's possible to specify multiple attributes, but it's not consistent with how the asciidoctor commandline works. Right now, you have to separate the attributes by spaces:

asciidoctorjs -a 'icons=font linkcss' sample.adoc

Ideally, it should be possible to specify the -a flag multiple times:

asciidoctorjs -a icons=font -a linkcss sample.adoc

However, that depends on array support in the cli package (see node-js-libs/cli#62).

As an alternative, we should allow attributes to be separated by commas so that quotes are not needed:

asciidoctorjs -a icons=font,linkcss sample.adoc

(this syntax used to be possible in Asciidoctor core, but was dropped).

If no change is made to the code, we should at least document in the README how to specify multiple attributes since it is different from the asciidoctor command.

@ggrossetie
Copy link
Member

As suggested by @mojavelinux we should switch to https://www.npmjs.com/package/yargs

ggrossetie added a commit to ggrossetie/asciidoctor-cli.js that referenced this issue Apr 14, 2018
ggrossetie added a commit to ggrossetie/asciidoctor-cli.js that referenced this issue Apr 21, 2018
ggrossetie added a commit that referenced this issue Apr 28, 2018
Resolves #12, replace cli by yargs
@mojavelinux
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants