Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolves #12, replace cli by yargs #32

Merged
merged 2 commits into from
Apr 28, 2018

Conversation

ggrossetie
Copy link
Member

This is a work in progress because I need to write tests! 💪

@ggrossetie
Copy link
Member Author

@mojavelinux I've restructured the code to be able to test it (without rewire)

@mojavelinux
Copy link
Member

This is looking good!

Could you add a test for setting multiple attributes?

@ggrossetie
Copy link
Member Author

@mojavelinux Done 🎉

Copy link
Member

@mojavelinux mojavelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Nice work!

@ggrossetie ggrossetie merged commit 0242f22 into asciidoctor:master Apr 28, 2018
@ggrossetie ggrossetie deleted the issue-12-yargs branch December 2, 2018 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants