Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle various ts_project srcs labels syntaxes #571

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: handle various ts_project srcs labels syntaxes #571

merged 1 commit into from
Apr 11, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Mar 19, 2024 •
edited
Loading

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • New test cases added

@Aghassi
Copy link
Collaborator

Aghassi commented Mar 19, 2024

Confirmed this patch works on v2.2.0 internally

@jbedard jbedard requested a review from alexeagle March 19, 2024 20:32
jbedard
jbedard commented Mar 19, 2024
View reviewed changes
ts/private/ts_lib.bzl Outdated Show resolved Hide resolved
@jbedard jbedard requested a review from thesayyn March 19, 2024 21:10
@jbedard jbedard force-pushed the assets-badpath branch 5 times, most recently from be3a5c6 to 392f996 Compare April 11, 2024 05:03
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 11, 2024 •
edited
Loading

Test

All tests were cache hits

65 tests (100.0%) were fully cached saving 6s.

Buildifier      Format

@jbedard jbedard force-pushed the assets-badpath branch 3 times, most recently from 5044386 to fc875a8 Compare April 11, 2024 21:39
@jbedard jbedard changed the title fix(assets): allow targets as ts_project(assets) fix: handle various ts_project srcs labels syntaxes Apr 11, 2024
@jbedard jbedard force-pushed the assets-badpath branch 2 times, most recently from c4515e3 to 42665d2 Compare April 11, 2024 22:04
@jbedard jbedard merged commit 240253f into aspect-build:main Apr 11, 2024
30 checks passed
@jbedard jbedard mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeagle alexeagle alexeagle approved these changes

@Aghassi Aghassi Aghassi approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

Assignees
No one assigned
Labels
None yet
Projects
Open Source
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbedard @Aghassi @alexeagle