Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permit more label syntax when pre-computing outputs #585

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Member

fixes #584

@alexeagle alexeagle requested a review from jbedard April 11, 2024 21:31
Copy link

aspect-workflows bot commented Apr 11, 2024

Test

1 test target was executed and passed with no errors or flakes 🙌

Targets
//examples/srcs:test_generated [k8-fastbuild] 37ms

Total test execution time was 37ms. 63 tests (98.4%) were fully cached saving 6s.


Buildifier

Buildifier managed files require formatting

--- ./examples/srcs/BUILD.bazel	2024-04-11 21:37:55.687586677 +0000
+++ /tmp/buildifier-tmp-1219055211	2024-04-11 21:38:53.088045785 +0000
@@ -42,9 +42,9 @@
     # Demonstrates that you can mix sources with generated files
     # (Also verifies that relative labels work with macro logic for predeclared outputs)
     srcs = [
-        "//examples/srcs:a.ts",
         ":b.ts",
         ":generated.ts",
+        "//examples/srcs:a.ts",
     ],
     out_dir = "generated",
 )

💡 Run the following to apply the suggested formatting fixes

bazel run //:buildifier

Format

Formatting check has failed

💡 Some formatting failures can be fixed automatically by running the command below, while others may require manual fixes

bazel run //:format -- examples/srcs/BUILD.bazel

ℹ️ A patch file containing the changes has been archived as an artifact of this build

@jbedard
Copy link
Member

jbedard commented Apr 11, 2024

Done in #571

@jbedard jbedard closed this Apr 11, 2024
@jbedard jbedard deleted the bug_colon_start branch April 11, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: .ts source file labels produce invalid predeclared outputs unless they are bare
2 participants