Rely on Razors MalformedDirective identification for @page.

aspnet/Razor#1448
aspnet · Jul 5, 2017 · b064ef3 · b064ef3
1 parent 1eb7f9e
commit b064ef3
Showing 1 changed file with 5 additions and 22 deletions.
diff --git a/src/Microsoft.AspNetCore.Mvc.RazorPages/Infrastructure/PageDirectiveFeature.cs b/src/Microsoft.AspNetCore.Mvc.RazorPages/Infrastructure/PageDirectiveFeature.cs
@@ -50,20 +50,16 @@ static bool TryGetPageDirective(
             var documentIRNode = codeDocument.GetDocumentIntermediateNode();
             if (PageDirective.TryGetPageDirective(documentIRNode, out var pageDirective))
             {
+                if (pageDirective.DirectiveNode is MalformedDirectiveIntermediateNode malformedNode)
+                {
+                    logger.MalformedPageDirective(sourceDocument.FilePath, malformedNode.Diagnostics);
+                }
+
                 template = pageDirective.RouteTemplate;
                 return true;
             }
 
             template = null;
-
-            var visitor = new Visitor();
-            visitor.Visit(documentIRNode);
-            if (visitor.MalformedPageDirective != null)
-            {
-                logger.MalformedPageDirective(sourceDocument.FilePath, visitor.MalformedPageDirective.Diagnostics);
-                return true;
-            }
-
             return false;
         }
 
@@ -76,18 +72,5 @@ public void Configure(RazorParserOptionsBuilder options)
                 options.ParseOnlyLeadingDirectives = true;
             }
         }
-
-        private class Visitor : IntermediateNodeWalker
-        {
-            public MalformedDirectiveIntermediateNode MalformedPageDirective { get; private set; }
-
-            public override void VisitMalformedDirective(MalformedDirectiveIntermediateNode node)
-            {
-                if (node.Descriptor == PageDirective.Directive)
-                {
-                    MalformedPageDirective = node;
-                }
-            }
-        }
     }
 }