This repository has been archived by the owner on Dec 19, 2018. It is now read-only.
@page should look at malformed directives and attempt to classify a document as a page. #1448
Comments
NTaylorMullen
added a commit
to aspnet/Mvc
that referenced
this issue
Jun 20, 2017
- This will be reverted once aspnet/Razor#1448 has been completed.
NTaylorMullen
added a commit
that referenced
this issue
Jul 4, 2017
- The `@page` directive will now look for malformed directives and treat a view as a Razor page based on the existence of the malformed directive. - Updated the `PageDirective` type to contain a reference to its responsible directive node. - Added unit tests to validate malformed directives were picked up accordingly. - Updated code generation test baselines to reflect the new malformed directive understanding. #1448
|
@NTaylorMullen - done? |
|
@rynowak nope, waiting for your review on the PR. |
NTaylorMullen
added a commit
to aspnet/Mvc
that referenced
this issue
Jul 5, 2017
NTaylorMullen
added a commit
to aspnet/Mvc
that referenced
this issue
Jul 5, 2017
NTaylorMullen
added a commit
that referenced
this issue
Jul 5, 2017
- The `@page` directive will now look for malformed directives and treat a view as a Razor page based on the existence of the malformed directive. - Updated the `PageDirective` type to contain a reference to its responsible directive node. - Added unit tests to validate malformed directives were picked up accordingly. - Updated code generation test baselines to reflect the new malformed directive understanding. #1448
NTaylorMullen
added a commit
that referenced
this issue
Jul 5, 2017
- The `@page` directive will now look for malformed directives and treat a view as a Razor page based on the existence of the malformed directive. - Updated the `PageDirective` type to contain a reference to its responsible directive node. - Added unit tests to validate malformed directives were picked up accordingly. - Updated code generation test baselines to reflect the new malformed directive understanding. #1448
NTaylorMullen
added a commit
to aspnet/Mvc
that referenced
this issue
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
With the new Razor error story we transform malformed
@pagedirectives intoMalformedDirectiveIRNodes which in turn result in pages not being classified as Razor pages. This impacts the way Mvc routes to said pages; we should be smarter and also inspect malformed directives to determine our "pageness"The text was updated successfully, but these errors were encountered: