Have @page understand malformed directives.
#1506
Conversation
There was a problem hiding this comment.
Can you have a PR for https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.RazorPages/Infrastructure/PageDirectiveFeature.cs#L13 ready since this would mess up the logging here (https://github.com/aspnet/Mvc/blob/dev/src/Microsoft.AspNetCore.Mvc.RazorPages/Infrastructure/PageDirectiveFeature.cs#L51)?
| public DirectiveIntermediateNode DirectiveNode { get; private set; } | ||
| public IntermediateNode DirectiveNode { get; private set; } | ||
|
|
||
| public IEnumerable<DirectiveTokenIntermediateNode> DirectiveTokens { get; private set; } |
There was a problem hiding this comment.
Why set this? As opposed to just doing node.DirectiveTokens at the callsite?
There was a problem hiding this comment.
The DirectiveNode is an IntermediateNode because it can be a malformed node or a non-malformed node.
Will do. |
- The `@page` directive will now look for malformed directives and treat a view as a Razor page based on the existence of the malformed directive. - Updated the `PageDirective` type to contain a reference to its responsible directive node. - Added unit tests to validate malformed directives were picked up accordingly. - Updated code generation test baselines to reflect the new malformed directive understanding. #1448
NTaylorMullen
force-pushed
the
nimullen/1448
branch
from
e6df657
to
11920e6
Compare
@pagedirective will now look for malformed directives and treat a view as a Razor page based on the existence of the malformed directive.PageDirectivetype to contain a reference to its responsible directive node.#1448
/cc @rynowak @pranavkm