Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

OOM when using MVC solution in VS #2681

Closed
davidfowl opened this issue Sep 11, 2015 · 3 comments
Closed

OOM when using MVC solution in VS #2681

davidfowl opened this issue Sep 11, 2015 · 3 comments
Assignees
@davidfowl
Labels
3 - Done bug
Milestone
1.0.0-beta8

Comments

@davidfowl
Copy link
Member

Seems we're holding onto a bunch more library descriptions. This can easily be fixed by caching more strings, versions, package ids, paths.
@davidfowl davidfowl self-assigned this Sep 11, 2015
@davidfowl davidfowl added this to the 1.0.0-beta8 milestone Sep 11, 2015
davidfowl added a commit that referenced this issue Sep 19, 2015
@davidfowl
Don't hold onto the ApplicationContext in DTH
dcc92a5 
#2681
@davidfowl davidfowl mentioned this issue Sep 19, 2015
Merged
davidfowl added a commit that referenced this issue Sep 20, 2015
@davidfowl
Remove LibraryExporter cache
82c18bc 
- Create one every time. The memory is all working memory and
doesn't need to be held onto.

#2681
@davidfowl davidfowl mentioned this issue Sep 20, 2015
Merged
@davidfowl
Copy link
Member Author

@rynowak let me know if you see the problem still. The changes drop the memory that is being held onto. There's another issue to just reduce allocations in general which will be submitted later.

@rynowak
Copy link
Member

rynowak commented Sep 23, 2015

This is still happening. There's too much stuff rooted - I get into this state working with either MVC solution for about an hour.

image

Dump is available on corpnet.

@rynowak rynowak reopened this Sep 23, 2015
davidfowl added a commit that referenced this issue Sep 25, 2015
@davidfowl
Several DTH and compilation performance improvements
80855f2 
- There were some general regressions from beta7 to beta8 wrt
performance of DTH and compilation. This fix intends to rectify those
and also improve some on some of the older logic (<= beta7)
- Don't create the build time load context until required. For it's
not needed unless a compile module is being loaded or a custom compiler
is being loaded.
- The LibraryExporter no longer holds onto the build load context
- Fixed a disposal caching bug
- Nuke IProjectGraphProvider because it provided no real value
- Made ProjectExportContext which acts as a disposable cache entry
for the build time load context.
- Added friendly name to LoadContext for easy debugging
- Removed background compilation from DTH as it was harmful for large
solutions. Things are only compiled on demand now.
- ProjectAssemblyLoader will only take the subset of project that it needs

#2681
@davidfowl davidfowl mentioned this issue Sep 25, 2015
Closed
@davidfowl
Copy link
Member Author

@rynowak if you see more issues, please reopen again 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
2 participants
@davidfowl @rynowak