This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Several DTH and compilation performance improvements #2827
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There were some general regressions from beta7 to beta8 wrt performance of DTH and compilation. This fix intends to rectify those and also improve some on some of the older logic (<= beta7) - Don't create the build time load context until required. For it's not needed unless a compile module is being loaded or a custom compiler is being loaded. - The LibraryExporter no longer holds onto the build load context - Fixed a disposal caching bug - Nuke IProjectGraphProvider because it provided no real value - Made ProjectExportContext which acts as a disposable cache entry for the build time load context. - Added friendly name to LoadContext for easy debugging - Removed background compilation from DTH as it was harmful for large solutions. Things are only compiled on demand now. - ProjectAssemblyLoader will only take the subset of project that it needs #2681
| @@ -0,0 +1,83 @@ | |||
| using System; | |||
There was a problem hiding this comment.
License and registration please.
|
|
after fixing minor issues
| ICompilationEngine compilationEngine, | ||
| IAssemblyLoadContext defaultContext) | ||
| IAssemblyLoadContext defaultContext) : base(friendlyName) | ||
| { | ||
| // TODO: Make this all lazy | ||
| // TODO: Unify this logic with default host | ||
| var projects = libraries.Where(p => p.Type == LibraryTypes.Project) |
There was a problem hiding this comment.
Just use OfType<ProjectDescription> could be enough, right?
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some general regressions from beta7 to beta8 wrt performance of DTH and compilation. This fix intends to rectify thoseand also improve on some of the older logic (<= beta7)
not needed unless a compile module is being loaded or a custom compiler
is being loaded.
for the build time load context.
solutions. Things are only compiled on demand now.
OOM when using MVC solution in VS #2681
/cc @rynowak @troydai