-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bool expression comment placement #7269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
MichaReiser
force-pushed
the
bool-op-binary-like
branch
from
September 11, 2023 13:37
e5412e9
to
dc2c8dc
Compare
konstin
approved these changes
Sep 11, 2023
crates/ruff_python_formatter/resources/test/fixtures/ruff/expression/boolean_operation.py
Outdated
Show resolved
Hide resolved
nice work on the compatibility! |
MichaReiser
force-pushed
the
bool-op-binary-like
branch
from
September 12, 2023 06:24
dc2c8dc
to
6ffae39
Compare
CodSpeed Performance ReportMerging #7269 will degrade performances by 3.73%Comparing Summary
Benchmarks breakdown
|
konstin
reviewed
Sep 12, 2023
let comments = f.context().comments().clone(); | ||
let expression_comments = comments.leading_dangling_trailing(expression); | ||
|
||
// Format leading comments that are before the inner most `(` outside of the expression's parentheses. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all comment placement issues for boolean expression (
and
,or
) for the django project bya) Rewriting the boolean expression formatting to use the BinaryLike formatting to get consistent formatting for all binary like expressions
b) Making
a\n # comment\n and b
a trailing comment ofa
the same as for binary expressionsc) Respecting whether a comment was inside or outside of the parentheses when formatting a parenthesized expression.
Closes #7004
Closes #6062
Test Plan
Added tests
this PR
main