Skip to content

Commit

Permalink
add .env for a straightforward dev deployment (#354)
Browse files Browse the repository at this point in the history
## Description

In the process of setting up the dev environment, an empty .env file is
requested to build the image. Since there is no visible impact on having
it not having it, for consistency it is better to remove this not used
dependency from the docker compose yml file.

## Related Issue(s)

somehow related to #342 

## Breaking Change?

No major changes are going to happen

## Checklist

- [ ] I have made corresponding changes to the documentation (if
required)
- [ ] I have added tests that prove my fix is effective or that my
feature works

---------

Co-authored-by: giovanni.corsetti <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Harel Shein <[email protected]>
  • Loading branch information
4 people authored Jul 27, 2023
1 parent 2265e16 commit 1d27bbc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ celerybeat.pid
*.sage.py

# Environments
.env
.venv
env/
venv/
Expand Down
8 changes: 8 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,14 @@
# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks
repos:
- repo: local
hooks:
- id: check-env-file
name: Check if .env file is empty
entry: bash -c 'FILE=dev/.env; if [ -s "$FILE" ]; then echo "$FILE is not empty. Please remove its content."; exit 1; fi'
language: system
types: [file]
pass_filenames: false
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v4.4.0
hooks:
Expand Down
Empty file added dev/.env
Empty file.

0 comments on commit 1d27bbc

Please sign in to comment.