add .env for a straightforward dev deployment #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
tatiana
reviewed
Jul 3, 2023
CorsettiS
changed the title
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
===========================================
- Coverage 91.28% 79.53% -11.75%
===========================================
Files 48 48
Lines 1686 1686
===========================================
- Hits 1539 1341 -198
- Misses 147 345 +198 ☔ View full report in Codecov by Sentry. |
harels
approved these changes
Jul 27, 2023
tatiana
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description In the process of setting up the dev environment, an empty .env file is requested to build the image. Since there is no visible impact on having it not having it, for consistency it is better to remove this not used dependency from the docker compose yml file. ## Related Issue(s) somehow related to #342 ## Breaking Change? No major changes are going to happen ## Checklist - [ ] I have made corresponding changes to the documentation (if required) - [ ] I have added tests that prove my fix is effective or that my feature works --------- Co-authored-by: giovanni.corsetti <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Harel Shein <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the process of setting up the dev environment, an empty .env file is requested to build the image. Since there is no visible impact on having it not having it, for consistency it is better to remove this not used dependency from the docker compose yml file.
Related Issue(s)
somehow related to #342
Breaking Change?
No major changes are going to happen
Checklist