-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor tests to be separated from application code #313
Conversation
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 88.42% 88.43%
=======================================
Files 41 41
Lines 1279 1280 +1
=======================================
+ Hits 1131 1132 +1
Misses 148 148
☔ View full report in Codecov by Sentry. |
c071619
to
1255831
Compare
does this include the profiles changes too? |
@jlaneve just moved the new files as well! Some of the new profile tests are failing. Could we pair to troubleshoot them? |
tests are failing bc of the datasets - digging into this now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for making this change! this is great 🙂
Closes: #302