Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests to be separated from application code #313

Merged
merged 3 commits into from
Jun 8, 2023
Merged

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Jun 6, 2023

Closes: #302

@tatiana tatiana requested a review from a team as a code owner June 6, 2023 12:26
@tatiana tatiana requested a review from a team June 6, 2023 12:26
@netlify
Copy link

netlify bot commented Jun 6, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 3c7a152
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/648216849e72060007d04cf6

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (374f8a1) 88.42% compared to head (3c7a152) 88.43%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   88.42%   88.43%           
=======================================
  Files          41       41           
  Lines        1279     1280    +1     
=======================================
+ Hits         1131     1132    +1     
  Misses        148      148           
Impacted Files Coverage Δ
cosmos/providers/dbt/dataset.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tatiana tatiana force-pushed the refactor-tests branch 2 times, most recently from c071619 to 1255831 Compare June 7, 2023 14:18
@jlaneve
Copy link
Collaborator

jlaneve commented Jun 7, 2023

does this include the profiles changes too?

@tatiana
Copy link
Collaborator Author

tatiana commented Jun 8, 2023

@jlaneve just moved the new files as well! Some of the new profile tests are failing. Could we pair to troubleshoot them?

@jlaneve
Copy link
Collaborator

jlaneve commented Jun 8, 2023

tests are failing bc of the datasets - digging into this now

Copy link
Collaborator

@jlaneve jlaneve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for making this change! this is great 🙂

@jlaneve jlaneve merged commit 4e38f7b into main Jun 8, 2023
@jlaneve jlaneve deleted the refactor-tests branch June 8, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests outside the application code folder
2 participants