Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tests outside the application code folder #302

Closed
tatiana opened this issue Jun 1, 2023 · 0 comments · Fixed by #313
Closed

Move tests outside the application code folder #302

tatiana opened this issue Jun 1, 2023 · 0 comments · Fixed by #313
Assignees
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Jun 1, 2023

Currently, the tests are together with the application code.

The goal of this ticket is to move them to their own directory tests in the root, having a similar folder directory structure to the application code.

Some motivations:

  • The Python Packaging Authority recommends separating the test directory from the application code (src)
  • We are not distributing tests with the application, and we have tests which do not match 1:1 files, such as the integration example DAGs tests (what PyTest says about structure)
  • This is a pattern established not only in Airflow and many major Python projects but also in most (if not all) Astronomer Python projects, including Astro SDK, Multitenancy, providers packages and ​​even our template repository)
@tatiana tatiana added this to the 1.0.0 milestone Jun 1, 2023
@tatiana tatiana changed the title Move tests outside the application code Move tests outside the application code folder Jun 1, 2023
tatiana added a commit that referenced this issue Jun 6, 2023
tatiana added a commit that referenced this issue Jun 6, 2023
tatiana added a commit that referenced this issue Jun 7, 2023
@tatiana tatiana self-assigned this Jun 7, 2023
tatiana added a commit that referenced this issue Jun 8, 2023
jlaneve added a commit that referenced this issue Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants