Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy Preview for amazing-pothos-a3bca0 processing.
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 92.88% 92.83% -0.06%
==========================================
Files 49 49
Lines 1968 1982 +14
==========================================
+ Hits 1828 1840 +12
- Misses 140 142 +2
☔ View full report in Codecov by Sentry. |
tatiana
approved these changes
Sep 28, 2023
There was a problem hiding this comment.
Thanks for this impressive quick fix, @raffifu!
Is there any chance you could add a unit test to cover
cosmos/dbt/parser/project.py#L368?
We'll release this fix as part of the 1.2 release - we should have an alpha pre-release soon.
tatiana
changed the title
tatiana
pushed a commit
that referenced
this pull request
Sep 28, 2023
tatiana
added a commit
that referenced
this pull request
Sep 28, 2023
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
Merged
tatiana
added a commit
that referenced
this pull request
Sep 28, 2023
Bug fixes * Only create task group and test task only if the model has a test by @raffifu in #543 * Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563 * Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565 * Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 by @tatiana in #564
tatiana
added a commit
that referenced
this pull request
Sep 29, 2023
Bug fixes
* Only create task group and test task only if the model has a test by
@raffifu in #543
* Fix parsing test nodes when using the custom load method
(`LoadMethod.CUSTOM`) by @raffifu in #563
* Fix `DbtTestOperator` when test does not have ``test_metadata`` by
@javihernovoa and @tatiana in #565
* Support dbt 1.6 and `apache-airflow-providers-cncf-kubernetes` 7.3.0
by @tatiana in #564
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR Added a functionality to parse Test on the custom parser. After implementing #543, there's an issue using
load_via_custom_parserwhich doesn't load the test node. That's happen because the implementation in #543 is assume all node doesn't has test. After debugging, i found that theload_via_custom_parsernot return any tests node.Related Issue(s)
closes #561
Checklist