Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 #564

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Sep 28, 2023

Cosmos tests broke when dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 were released. There was a quick fix, #426, so the CI wouldn't be red, but that meant we didn't officially support the latest version of dbt if users wanted to run both Cosmos and dbt in the same Python virtualenv.

This feature has been requested by a few community members via Airflow Slack #airflow-dbt channel:

Closes: #444

This change was validated by:

  • Running tests locally (Python 3.8 and Airflow 2.7)
  • Creating a virtualenv with the latest versions
  • Running the dags basic_cosmos_dag and jaffle_shop_kubernetes

@netlify
Copy link

netlify bot commented Sep 28, 2023

👷 Deploy Preview for amazing-pothos-a3bca0 processing.

Name Link
🔨 Latest commit 8ec4452
🔍 Latest deploy log https://app.netlify.com/sites/amazing-pothos-a3bca0/deploys/6515707c29f6570008d7b63c

@tatiana tatiana temporarily deployed to internal September 28, 2023 12:14 — with GitHub Actions Inactive
@tatiana tatiana changed the title Add support to dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 WIP: Add support to dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 Sep 28, 2023
@tatiana tatiana temporarily deployed to internal September 28, 2023 12:24 — with GitHub Actions Inactive
@tatiana tatiana changed the title WIP: Add support to dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 Add support to dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 Sep 28, 2023
@tatiana tatiana changed the title Add support to dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0 Sep 28, 2023
@tatiana tatiana marked this pull request as ready for review September 28, 2023 12:52
@tatiana tatiana requested a review from a team as a code owner September 28, 2023 12:52
@tatiana tatiana requested a review from a team September 28, 2023 12:52
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (15258bf) 92.89% compared to head (8ec4452) 92.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #564   +/-   ##
=======================================
  Coverage   92.89%   92.89%           
=======================================
  Files          49       49           
  Lines        1970     1970           
=======================================
  Hits         1830     1830           
  Misses        140      140           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@harels harels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad to see we can support the new version!

@harels harels merged commit 85f4f3b into main Sep 28, 2023
41 checks passed
@harels harels deleted the dbt-1.6 branch September 28, 2023 14:44
tatiana added a commit that referenced this pull request Sep 28, 2023
Bug fixes

* Only create task group and test task only if the model has a test by @raffifu in #543
* Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563
* Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565
* Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0  by @tatiana in #564
@tatiana tatiana mentioned this pull request Sep 28, 2023
tatiana added a commit that referenced this pull request Sep 28, 2023
Bug fixes

* Only create task group and test task only if the model has a test by @raffifu in #543
* Fix parsing test nodes when using the custom load method (LoadMethod.CUSTOM) by @raffifu in #563
* Fix ``DbtTestOperator`` when test does not have ``test_metadata`` by @javihernovoa and @tatiana in #565
* Support dbt 1.6 and apache-airflow-providers-cncf-kubernetes 7.3.0  by @tatiana in #564
@tatiana tatiana added this to the 1.2.0 milestone Sep 29, 2023
@tatiana
Copy link
Collaborator Author

tatiana commented Sep 29, 2023

tatiana added a commit that referenced this pull request Sep 29, 2023
Bug fixes
    
* Only create task group and test task only if the model has a test by
@raffifu in #543
* Fix parsing test nodes when using the custom load method
(`LoadMethod.CUSTOM`) by @raffifu in #563
* Fix `DbtTestOperator` when test does not have ``test_metadata`` by
@javihernovoa and @tatiana in #565
* Support dbt 1.6 and `apache-airflow-providers-cncf-kubernetes` 7.3.0
by @tatiana in #564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dbt >= 1.6 breaks cosmos
2 participants