Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add stream::max_by method #384

Merged
merged 7 commits into from
Oct 29, 2019
Merged

add stream::max_by method #384

merged 7 commits into from
Oct 29, 2019

Conversation

yjhmelody
Copy link
Contributor

@yjhmelody yjhmelody commented Oct 23, 2019 •
edited
Loading

I impl it by reference min_by.
Though altering x.cmp(y) to y.cmp(x) can also do the same thing.

#129

taiki-e
taiki-e reviewed Oct 26, 2019
View reviewed changes
src/stream/stream/max_by.rs Outdated Show resolved Hide resolved
src/stream/stream/max_by.rs Outdated Show resolved Hide resolved
src/stream/stream/max_by.rs Outdated Show resolved Hide resolved
@taiki-e taiki-e mentioned this pull request Oct 26, 2019
Merged
@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Oct 28, 2019
yoshuawuyts
yoshuawuyts approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@yoshuawuyts yoshuawuyts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work; thanks so much!

@yoshuawuyts yoshuawuyts merged commit 2b1c6f0 into async-rs:master Oct 29, 2019
@yoshuawuyts yoshuawuyts mentioned this pull request Oct 29, 2019
Closed
@yjhmelody yjhmelody deleted the stream-max_by branch October 29, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e left review comments

@yoshuawuyts yoshuawuyts yoshuawuyts approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yjhmelody @zzz6519003 @yoshuawuyts @taiki-e