Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of actions-rs/clippy-check #392

Merged
merged 2 commits into from
Oct 28, 2019
Merged

Conversation

taiki-e
Copy link
Contributor

@taiki-e taiki-e commented Oct 26, 2019

#286, #384, and #385's CI is failing because of this error. I think this action is broken.

https://github.com/async-rs/async-std/pull/286/checks?check_run_id=276113673:

##[error]Unable to create clippy annotations! Reason: HttpError: Resource not accessible by integration
##[warning]It seems that this Action is executed from the forked repository.
##[warning]GitHub Actions are not allowed to create Check annotations, when executed for a forked repos. See https://github.com/actions-rs/clippy-check/issues/2 for details.
Posting clippy checks here instead.

Related: actions-rs/clippy-check#2 (comment)

@taiki-e taiki-e requested review from a user and yoshuawuyts October 26, 2019 17:34
@taiki-e
Copy link
Contributor Author

taiki-e commented Oct 26, 2019

Nope, CI fails are due to clippy bug...

error: do not call a function with mutable arguments inside of `debug_assert!`
  --> src/io/buf_read/read_line.rs:40:27
   |
40 |             debug_assert!(buf.is_empty());
   |                           ^^^^^^^^^^^^^^
   |
   = note: `#[deny(clippy::debug_assert_with_mut_call)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#debug_assert_with_mut_call

UPDATE: filed rust-lang/rust-clippy#4737

@ghost
Copy link

ghost commented Oct 26, 2019

Let's just delete the whole Clippy check? I think Clippy is useful during development but is not really suitable for continuous integration :)

@taiki-e
Copy link
Contributor Author

taiki-e commented Oct 26, 2019

Let's just delete the whole Clippy check? I think Clippy is useful during development but is not really suitable for continuous integration :)

I think we should use the beta's clippy. nightly's clippy often adds broken lint, so I think it's not really suitable for CI.

@skade
Copy link
Collaborator

skade commented Oct 28, 2019

Let's try out Beta for a while and see if it improves things.

@skade skade merged commit f262fd8 into async-rs:master Oct 28, 2019
@taiki-e taiki-e deleted the clippy branch October 31, 2019 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants