Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Special cases in enum values fails to generate accurate enum keys for Java generator #502

Closed
jonaslagoni opened this issue Nov 3, 2021 · 2 comments · Fixed by #526
Closed

Special cases in enum values fails to generate accurate enum keys for Java generator #502

jonaslagoni opened this issue Nov 3, 2021 · 2 comments · Fixed by #526
Labels
bug Something isn't working good first issue Good for newcomers Java generator Anything related to the Java generator released

Comments

@jonaslagoni
Copy link
Member

Describe the bug

Thanks to @panwauu, we already have it solved in the TS generator, see #450 and fix in #497.

We need to apply the same fix we did here:

modelina/src/generators/typescript/renderers/EnumRenderer.ts

Line 53 in 2a8659d

key = FormatHelpers.replaceSpecialCharacters(String(value), { exclude: [' '], separator: '_' });

to this line:

modelina/src/generators/java/renderers/EnumRenderer.ts

Line 52 in 2a8659d

key = String(value);

@jonaslagoni jonaslagoni added bug Something isn't working good first issue Good for newcomers Java generator Anything related to the Java generator labels Nov 3, 2021
@jonaslagoni jonaslagoni changed the title Special cases in enum values fails to generate accurate enum output for Java generator Special cases in enum values fails to generate accurate enum keys for Java generator Nov 3, 2021
quadrrem pushed a commit to quadrrem/modelina that referenced this issue Dec 13, 2021
fix: special characters in java enum values (asyncapi#502)
21fcb1c
@quadrrem quadrrem mentioned this issue Dec 13, 2021
Merged
@quadrrem
Copy link
Contributor

I gave it a shot in the PR #526 above, please let me know what you think.

asyncapi-bot pushed a commit that referenced this issue Dec 14, 2021
@quadrrem
fix: special characters in java enum values (#502)
615eb60
@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 0.39.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers Java generator Anything related to the Java generator released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: special characters in java enum values (#502) quadrrem/modelina
3 participants
@quadrrem @jonaslagoni @asyncapi-bot