Merge pull request #16 from jakejohns/hotfix/persist-many2many

Fix Many-to-Many persistence
atlasphp · Mar 31, 2021 · 2ef750a · 2ef750a
2 parents e773d71 + 28de9e3
commit 2ef750a
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src/Relationship/ManyToMany.php b/src/Relationship/ManyToMany.php
@@ -206,16 +206,18 @@ public function persistForeign(Record $nativeRecord, SplObjectStorage $tracker)
         $throughRecordSet = $nativeRecord->{$this->throughName};
         $throughRecords = $throughRecordSet->getRecords();
 
+        foreach ($throughRecords as $throughRecord) {
+            // set for deletion, unless it matches
+            $throughRecord->setDelete(true);
+        }
+
         // find foreigns with a matching through
         foreach ($foreignRecordSet as $foreignRecord) {
 
             // does the foreign match any through?
             $matched = false;
             foreach ($throughRecords as $i => $throughRecord) {
 
-                // set for deletion, unless it matches
-                $throughRecord->setDelete(true);
-
                 // does this through match the foreign?
                 if ($this->recordsMatch($throughRecord, $foreignRecord)) {
                     // matched