Fix Many-to-Many persistence #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close atlasphp/Atlas.Orm#105 Close atlasphp/Atlas.Orm#107 `setDelete` all through relationships unless they match. Fixes issue with detaching all related etc.
|
PR makes sense and looks good :) |
|
Would it be possible to capture the bug in a unit test, showing the PR fixes it? |
|
Looks OK to me. Thanks @jakejohns ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close atlasphp/Atlas.Orm#105
Close atlasphp/Atlas.Orm#107
setDeleteall through relationships unless they match.Fixes issue with detaching all related etc.