Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

feat: Add a command to delete items permanently #1373

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

aminya
Copy link

@aminya aminya commented Dec 28, 2020

Description of the Change

This adds a command to delete items permanently. It uses the Sift+delete shortcut similar to operating system shortcuts. It prompts before doing so.

Benefits

  • Allows deleting files permanently
  • Provides a way to avoid the issues mentioned in the next section

Applicable Issues

This PR does not provide an alternative trashing implementation for tree-view:remove, but it provides a new command to avoid these issues by using tree-view:remove-permanently. In later PRs, we can use the trash package as a fallback to fix and close these issues:
#1368
#1237
#345
#1046

Possible Drawbacks

none

@aminya aminya changed the title feat: Add a command to delete items permanently feat: Add a command to delete items permanently on MacOS Dec 28, 2020
@aminya aminya changed the title feat: Add a command to delete items permanently on MacOS feat: Add a command to delete items permanently Dec 28, 2020
@aminya aminya force-pushed the permanently-delete branch 2 times, most recently from 283345c to 2c1f70b Compare December 28, 2020 08:20
@aminya aminya force-pushed the permanently-delete branch 2 times, most recently from 788c650 to ed3e763 Compare December 28, 2020 08:32
@aminya aminya force-pushed the permanently-delete branch 4 times, most recently from 540afa1 to 6b500f7 Compare December 28, 2020 10:09
@aminya aminya mentioned this pull request Mar 13, 2021
1 task
Copy link
Contributor

@sadick254 sadick254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feature. I have noticed that this feature has no specs. Would you mind adding some specs on it?

@aminya
Copy link
Author

aminya commented Apr 9, 2021

I don't know why the test failed again. It was working 😥 Writing tests with CoffeeScript 1 and Jasmine 1 is a very bad experience.

@aminya
Copy link
Author

aminya commented Apr 9, 2021

The issue was that I was comparing arrays and objects together using == instead of a deep equality. I fixed the issue now.

@darangi
Copy link
Contributor

darangi commented Mar 30, 2022

Thanks for the contribution 🙇🏾‍♂️ .

Could you fix the conflicts?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants