Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

feat: Add a command to delete items permanently #1373

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: Add a command to delete items permanently #1373

wants to merge 14 commits into from

Commits on Dec 28, 2020

  1. feat: Add a command to delete items permanently

    @aminya
    aminya committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    fc6f257 View commit details
    Browse the repository at this point in the history

  2. refactor: finishRemoval 

    This will be used in the next commit
    @aminya
    aminya committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    e508a01 View commit details
    Browse the repository at this point in the history

  3. feat: use del to remove the files as a fallback when shouldDeletePerm… 

    …anently
    @aminya
    aminya committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    a51d998 View commit details
    Browse the repository at this point in the history

  4. refactor: removeSelectedEntriesPermanently

    @aminya
    aminya committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    37ee0cd View commit details
    Browse the repository at this point in the history

  5. ci: use node 12 on windows

    @aminya
    aminya committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    e3a5650 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2021

  1. fix: call will-delete-entry before permanently deleting

    @aminya
    aminya committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    1ad2434 View commit details
    Browse the repository at this point in the history

  2. return del promise

    @aminya
    aminya committed Apr 8, 2021
    Configuration menu
    Copy the full SHA
    a23facd View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2021

  1. test: add tests for remove-permanently

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    c868589 View commit details
    Browse the repository at this point in the history

  2. test: andCallFake atom.confirm

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    7f2decd View commit details
    Browse the repository at this point in the history

  3. test: use call to make sure this is defined

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    28bba00 View commit details
    Browse the repository at this point in the history

  4. fix: use fat arrows to make sure this is defined

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    c8b942b View commit details
    Browse the repository at this point in the history

  5. test: add onWillDeleteEntry, onEntryDeleted, finishRemoval emitter calls

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    42a03c6 View commit details
    Browse the repository at this point in the history

  6. test: fix the failing tests

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    52a572b View commit details
    Browse the repository at this point in the history

  7. test: convert waitsFor to runs

    @aminya
    aminya committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    cc20188 View commit details
    Browse the repository at this point in the history