Skip to content

Commit

Permalink
Make Identity of BuildProblem in TeamCityProvider optional
Browse files Browse the repository at this point in the history
  • Loading branch information
augustoproiete committed Jun 29, 2020
1 parent 09ccb25 commit 7cdabe4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Cake.Common/Build/TeamCity/ITeamCityProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ public interface ITeamCityProvider
/// </summary>
/// <param name="description">A human-readable plain text describing the build problem. By default, the description appears in the build status text and in the list of build's problems. The text is limited to 4000 symbols, and will be truncated if the limit is exceeded.</param>
/// <param name="identity">A unique problem ID (optional). Different problems must have different identity, same problems - same identity, which should not change throughout builds if the same problem, for example, the same compilation error occurs. It must be a valid Java ID up to 60 characters. If omitted, the identity is calculated based on the description text.</param>
void BuildProblem(string description, string identity);
void BuildProblem(string description, string identity = null);

/// <summary>
/// Tell TeamCity to import data of a given type.
Expand Down
2 changes: 1 addition & 1 deletion src/Cake.Common/Build/TeamCity/TeamCityProvider.cs
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ public void ImportDotCoverCoverage(FilePath snapshotFile, DirectoryPath dotCover
/// </summary>
/// <param name="description">A human-readable plain text describing the build problem. By default, the description appears in the build status text and in the list of build's problems. The text is limited to 4000 symbols, and will be truncated if the limit is exceeded.</param>
/// <param name="identity">A unique problem ID (optional). Different problems must have different identity, same problems - same identity, which should not change throughout builds if the same problem, for example, the same compilation error occurs. It must be a valid Java ID up to 60 characters. If omitted, the identity is calculated based on the description text.</param>
public void BuildProblem(string description, string identity)
public void BuildProblem(string description, string identity = null)
{
var tokens = new Dictionary<string, string> { { "description", description } };
if (!string.IsNullOrEmpty(identity))
Expand Down

0 comments on commit 7cdabe4

Please sign in to comment.