Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity of BuildProblem in TeamCityProvider should be optional #2811

Closed
augustoproiete opened this issue Jun 22, 2020 · 1 comment · Fixed by #2812
Closed

Identity of BuildProblem in TeamCityProvider should be optional #2811

augustoproiete opened this issue Jun 22, 2020 · 1 comment · Fixed by #2812
Assignees
Milestone

Comments

@augustoproiete
Copy link
Member

What You Are Seeing?

The identity argument of (I)TeamCityProvider.BuildProblem is required, but should be optional.

/// <summary>
/// Report a build problem to TeamCity.
/// </summary>
/// <param name="description">Description of build problem.</param>
/// <param name="identity">Build identity.</param>
void BuildProblem(string description, string identity);

Passing null or string.Empty works as expected (the code handles it correctly and omits the identity argument in the TeamCity service message).

What is Expected?

Either modify the method to have a default null value for the identity argument, or add an overload that only requires the description argument.

TeamCity docs describe the identity is optional.

image

What version of Cake are you using?

0.38.2

augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jun 22, 2020
augustoproiete added a commit to augustoproiete-forks/cake-build--cake that referenced this issue Jun 29, 2020
@devlead devlead added this to the v1.0.0 milestone Jun 29, 2020
@cake-build-bot
Copy link

🎉 This issue has been resolved in version v1.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

@augustoproiete augustoproiete self-assigned this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants