Remove some sdk usage from core logic #347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to move as much sdk usage related to blockchain environment (e.g.
current_account_id
,predecessor_account_id
) from core logic, pushing it tolib
(which is the boundary of our application). This will make it much easier to factor out blockchain context related lookups into a trait (as part of the standalone engine project).Note: this PR is built on top of #342 and #346 those should be reviewed and merged first. To see only the new changes from this PR only look at the diff from the last commit.